Use absolute URLs in footer links #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout_footer component was changed in Dec 2023[1] to make all links absolute. Unfortunately this broke our privacy notice and accessibility statement links because they became `<Plek.new.website_root>/<path>` (e.g. www.gov.uk/privacy-notice in production). Using the `_url` helper methods should mean that we're correctly linking to these pages in the Signon app. [1]: alphagov/govuk_publishing_components@1cdd65f
chrislo
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout_footer component was changed in Dec 2023 to make all links absolute. Unfortunately this broke our privacy notice and accessibility statement links because they became
<Plek.new.website_root>/<path>(e.g. www.gov.uk/privacy-notice in production). Using the_urlhelper methods should mean that we're correctly linking to these pages in the Signon app.