Remove cookie rotate code #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrislo
force-pushed
the
remove-cookie-rotator
branch
from
6aa743b
to
afe1513
Compare
We introduced this cookie rotation code in e711982 as part of the upgrade to Rails 7. Since our session cookies do not have a `Max-Age` or `Expires` attribute they are treated by the browsers as Session cookies and expire when the browser window is closed. I think it's safe to assume that all cookies issued under the old scheme (sometime before approximately April 13th 2022 when e711982 was made) have now been rotated, so this code can be removed.
chrislo
force-pushed
the
remove-cookie-rotator
branch
from
afe1513
to
d414685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced this cookie rotation code in e711982 as part of the upgrade to Rails 7. Since our session cookies do not have a
Max-AgeorExpiresattribute they are treated by the browsers as Session cookies and expire when the browser window is closed. I think it's safe to assume that all cookies issued under the old scheme (sometime before approximately April 13th 2022 when e711982 was made) have now been rotated, so this code can be removed.