Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dartsass-rails vs sassc-rails #2709

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Use dartsass-rails vs sassc-rails #2709

merged 4 commits into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. Move assets-related tasks into separate file 

    This code re-defines the assets-related tasks in order to avoid a load
of INFO-level warnings generated by the assets:precompile task [1].

It wasn't immediately obvious to me that was what was happening (even
though I made the change!). I think moving the code into a separate
`lib/tasks/assets.rake` file is more idiomatic and makes it slightly
more obvious what's going on.

[1]: #2179
    @floehopper
    floehopper committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    937c7eb View commit details
    Browse the repository at this point in the history

  2. Move from libsass -> dart-sass 

    I followed these instructions [1].

[1]: https://docs.publishing.service.gov.uk/manual/migrate-to-dart-sass-from-libsass.html
    @floehopper
    floehopper committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4d98987 View commit details
    Browse the repository at this point in the history

  3. Trigger dartsass:build task from assets:precompile task 

    The `dartsass-rails` gem does this enhancement automatically. However,
because we re-define the `assets:precompile` task, we lose the
enhancement and have to re-add it here.

c.f. alphagov/whitehall@13bd112
    @floehopper
    floehopper committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d1a2231 View commit details
    Browse the repository at this point in the history

  4. Fix Sass deprecation warning in table component 

    This fixes the following deprecation warning:

    Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
    Recommendation: math.div($sort-link-arrow-size, 2) or calc($sort-link-arrow-size / 2)
    More info and automated migrator: https://sass-lang.com/d/slash-div
    @floehopper
    floehopper committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    dc16605 View commit details
    Browse the repository at this point in the history