Show user status as tag instead of strikethrough #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristinaRO
force-pushed
the
280-use-govuk-tags-for-user-status
branch
2 times, most recently
from
b2fa1fc
to
39b356b
Compare
chrislo
approved these changes
Feb 14, 2024
CristinaRO
force-pushed
the
280-use-govuk-tags-for-user-status
branch
from
39b356b
to
61c1ec5
Compare
The strikethrough is not part of the design system, so we've decided to use the govuk-tag style instead. The design on the card showed green for active users, grey for suspended users, but there were no examples of locked or invited users. I've chosen to only use green for active users, and grey for all other statuses. At James' suggestion, I created a new method, `status_with_tag`, to avoid changing the display in other places where `status` is used, such as the CSV export of the users, and the summary view for user edit pages
CristinaRO
force-pushed
the
280-use-govuk-tags-for-user-status
branch
from
61c1ec5
to
35d09cb
Compare
Calum suggested it would be preferable to show API users' "Status" (instead of "Suspended?") on the API users table, similar to the Users table. This allows us to show the status tag as "Active" or "Suspended", in a similar way to the Users table, to create consistent expectations for users of the interface.
Now that we are showing the API users' status similar to the users' status, we can use the same helper method in the view. (There is precedent for this, as the edit view uses the same method, `summary_list_item_for_status`, for users and API users.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The strikethrough is not part of the design system, so we've decided to use the govuk-tag style instead.
The design on the card showed green for active users, grey for suspended users, but there were no examples of locked or invited users.
I've chosen to only use green for active users, and grey for all other statuses.
Trello
Screenshots
Users - before
Users - after
API users - before
API users - after
This application is owned by the Access & Permissions team.
Follow these steps if you are doing a Rails upgrade.