Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user status as tag instead of strikethrough #2713

Merged
merged 4 commits into from
Feb 15, 2024

Commits on Feb 14, 2024

  1. Show user status as tag instead of strikethrough

    The strikethrough is not part of the design system, so we've decided to
    use the govuk-tag style instead.
    
    The design on the card showed green for active users, grey for suspended
    users, but there were no examples of locked or invited users.
    
    I've chosen to only use green for active users, and grey for all other
    statuses.
    
    At James' suggestion, I created a new method, `status_with_tag`, to
    avoid changing the display in other places where `status` is used, such
    as the CSV export of the users, and the summary view for user edit pages
    CristinaRO committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2f794b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    35d09cb View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Show Status for API users rather than yes/no

    Calum suggested it would be preferable to show API users' "Status"
    (instead of "Suspended?") on the API users table, similar to the Users
    table.
    
    This allows us to show the status tag as "Active" or "Suspended", in a
    similar way to the Users table, to create consistent expectations for
    users of the interface.
    CristinaRO committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0b4c7c5 View commit details
    Browse the repository at this point in the history
  2. Use helper method for API users table

    Now that we are showing the API users' status similar to the users'
    status, we can use the same helper method in the view. (There is
    precedent for this, as the edit view uses the same method,
    `summary_list_item_for_status`, for users and API users.)
    CristinaRO committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    722561b View commit details
    Browse the repository at this point in the history