Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rails from 7.0.8 to 7.1.3.2 #2742

Merged
merged 11 commits into from
Feb 27, 2024
Merged

Conversation

brucebolt
Copy link
Member

@brucebolt brucebolt commented Feb 26, 2024

Bumps rails from 7.0.8 to 7.1.3.2.


updated-dependencies:

  • dependency-name: rails dependency-type: direct:production update-type: version-update:semver-minor ...

This application is owned by the Access & Permissions team.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Trello card

@brucebolt brucebolt force-pushed the dependabot/bundler/rails-7.1.3.2 branch 4 times, most recently from 8871346 to a2bc708 Compare February 26, 2024 16:28
dependabot bot and others added 2 commits February 26, 2024 16:30
Bumps [rails](https://github.com/rails/rails) from 7.0.8 to 7.1.3.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.0.8...v7.1.3.2)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@brucebolt brucebolt force-pushed the dependabot/bundler/rails-7.1.3.2 branch from c5db99b to 0bc1f48 Compare February 26, 2024 16:30
Rails 7.1 no longer adds autoloaded paths into `$LOAD_PATH`. However we
make use of this for the doorkeeper gem, so must keep this setting
enabled.
Prior to Rails 7.1, this defaulted to YAML. Now we must specify it.
This fixes the following warning:

```
DEPRECATION WARNING: Passing the class as positional argument is deprecated and will be removed in Rails 7.2.

Please pass the class as a keyword argument:

  serialize :applications_and_permissions, type: Hash
```
This fixes the following deprecation warning:

```
DEPRECATION WARNING: Setting action_dispatch.show_exceptions to false is
deprecated. Set to :none instead.
```
Prior to Rails 7.1, `ActionController::Parameters` was equivalent to
`Hash` when compared.

This has now been deprecated, so we need to explicitly include a hash
rather than assuming it'll be converted for us.
All deprecations and breaking changes have now been resolved, so we can
switch to Rails 7.1 defaults.
Rails 7.1 deprecates the use of Rails.application.secrets in favour of
`Rails.application.credentials`.

The credentials system introduces the burden of master encryption key
administration at no benefit to us, because we manage our production
secrets using environment variables instead of committing them to Git.

This commit loads the existing secret values and merges them into the
credentials object. This approach was copied from commit
8937b172be530a5d91bd999f4538e5a722dcab19 on the GOV.UK account-api
project.
This brings all gems up to date with the latest supported version.
This removes legacy migrations that have already been run in production.

Keeping around legacy migrations makes it difficult to identify which
code needs to be changed when making large scale changes and clutters
the results of searches.

Prior art for this occurred in 3797cd9.
@brucebolt brucebolt force-pushed the dependabot/bundler/rails-7.1.3.2 branch from 8827d74 to 4798e8b Compare February 26, 2024 16:47
@brucebolt brucebolt marked this pull request as ready for review February 26, 2024 16:56
Copy link
Contributor

@jkempster34 jkempster34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great and easy to follow! Thanks 🚢

This commit e9fbd26 references another commit. It might be nice to link to it for easy navigation https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#commit-shas

@jkempster34
Copy link
Contributor

All looks great and easy to follow! Thanks 🚢

This commit e9fbd26 references another commit. It might be nice to link to it for easy navigation https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#commit-shas

Huh, actually reading that article, what you've written should have autolinked anyway 🤷

@brucebolt
Copy link
Member Author

All looks great and easy to follow! Thanks 🚢
This commit e9fbd26 references another commit. It might be nice to link to it for easy navigation https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#commit-shas

Huh, actually reading that article, what you've written should have autolinked anyway 🤷

It appears to be autolinked from this page, but not the actual commit view itself 🤷‍♂️.

@brucebolt brucebolt merged commit a39f754 into main Feb 27, 2024
16 checks passed
@brucebolt brucebolt deleted the dependabot/bundler/rails-7.1.3.2 branch February 27, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants