Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rails from 7.0.8 to 7.1.3.2 #2745

Merged
merged 12 commits into from
Feb 27, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 27, 2024

Bumps rails from 7.0.8 to 7.1.3.2.

Release notes

Sourced from rails's releases.

v7.1.3.2

Active Support

  • No changes.

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • No changes.

Action Pack

  • Fix raise_on_missing_translations not working correctly with the translate method in controllers after the patch for CVE-2024-26143.

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

  • No changes.

... (truncated)

Commits
  • 6f0d1ad Preparing for 7.1.3.2 release
  • c25f0fc Respect raise_on_missing_ in controller
  • d73ed95 Preparing for 7.1.3.1 release
  • 43037d8 update changelog
  • 5187a9e fix XSS vulnerability when using translation
  • b4d3bfb Fix ReDoS in accept header scanning
  • 36c1591 Preparing for 7.1.3 release
  • a84622f Sync changelog
  • 1f505f0 Merge pull request #50771 from rails/backport-preview-nplus1
  • d8a8dd9 Merge pull request #50758 from rails/fix-video-preview-nplus1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Trello card

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Feb 27, 2024
Copy link

This application is owned by the Access & Permissions team.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@brucebolt brucebolt force-pushed the dependabot/bundler/rails-7.1.3.2 branch 2 times, most recently from 35c293e to 41b1fd1 Compare February 27, 2024 13:15
dependabot bot and others added 12 commits February 27, 2024 13:16
Bumps [rails](https://github.com/rails/rails) from 7.0.8 to 7.1.3.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.0.8...v7.1.3.2)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Rails 7.1 no longer adds autoloaded paths into `$LOAD_PATH`. However we
make use of this for the doorkeeper gem, so must keep this setting
enabled.
Prior to Rails 7.1, this defaulted to YAML. Now we must specify it.
This fixes the following warning:

```
DEPRECATION WARNING: Passing the class as positional argument is deprecated and will be removed in Rails 7.2.

Please pass the class as a keyword argument:

  serialize :applications_and_permissions, type: Hash
```
This fixes the following deprecation warning:

```
DEPRECATION WARNING: Setting action_dispatch.show_exceptions to false is
deprecated. Set to :none instead.
```
Prior to Rails 7.1, `ActionController::Parameters` was equivalent to
`Hash` when compared.

This has now been deprecated, so we need to explicitly include a hash
rather than assuming it'll be converted for us.
All deprecations and breaking changes have now been resolved, so we can
switch to Rails 7.1 defaults.
Rails 7.1 deprecates the use of Rails.application.secrets in favour of
`Rails.application.credentials`.

The credentials system introduces the burden of master encryption key
administration at no benefit to us, because we manage our production
secrets using environment variables instead of committing them to Git.

This commit loads the existing secret values and merges them into the
credentials object. This approach was copied from commit
8937b172be530a5d91bd999f4538e5a722dcab19 on the GOV.UK account-api
project.
This brings all gems up to date with the latest supported version.
This removes legacy migrations that have already been run in production.

Keeping around legacy migrations makes it difficult to identify which
code needs to be changed when making large scale changes and clutters
the results of searches.

Prior art for this occurred in 3797cd9.
In Rails 7.1, encryption uses SHA256 whereas Rails 7.0 uses SHA1. As we
have data encrypted in SHA1, we need to enable support.

A later PR will migrate all data to use SHA256, then we will remove
support for SHA1.
@brucebolt brucebolt force-pushed the dependabot/bundler/rails-7.1.3.2 branch from 41b1fd1 to 90d4cf0 Compare February 27, 2024 13:17
@brucebolt
Copy link
Member

This was previously attempted in #2742 and reverted in #2743.

@brucebolt brucebolt merged commit cde9c2e into main Feb 27, 2024
16 checks passed
@brucebolt brucebolt deleted the dependabot/bundler/rails-7.1.3.2 branch February 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants