Add logging to permission removal Rake task #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Rake task didn't have any count logging, so in order to be sure it worked, you'd have to run some of the code after (and also ideally before) running the Rake task to check the permission counts. This task has already been run, but we may reuse it in future and/or use it as a template for other similar Rake tasks, so we should make it more of a best practice example now
brucebolt
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
This Rake task didn't have any count logging, so in order to be sure it worked, you'd have to run some of the code after (and also ideally before) running the Rake task to check the permission counts. This task has already been run, but we may reuse it in future and/or use it as a template for other similar Rake tasks, so we should make it more of a best practice example now
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.