Commits on Jun 27, 2024

1. Fix applications tables column alignment …

   In #2341, the table component from `govuk_publishing_components` was
   copied over and customised
   
   In #2664, we migrated the applications tables to use this. In the
   process, we lost the custom classes on the first two columns, which set
   the widths to 1/4 and 1/3 respectively. This was noted as "acceptable"
   in the PR body in exchange for improved consistency and other benefits
   from using the component
   
   However, since we have a custom version of the table component, it's
   very easy for us to support custom classes. This was in fact done in the
   same PR that copies the component into the Signon codebase, adding
   custom class support for the outer table element in 4f09fbc
   
   This adds support for custom classes in the headers, which is then used
   to restore the old classes and therefore consistent column widths
   between tables (irrespective of content width)
   
   In #2341, it was suggested that we might try to get the customisations
   merged upstream - it might be worth exploring that with both this and
   earlier changes as a separate piece of work
   
   #2341: #2341
   #2664: #2664

   

   yndajas committed Jun 27, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6092dc1
   • Browse repository at this point

   Copy the full SHA

   6092dc1 View commit details

   Browse the repository at this point in the history