Show view permissions link even when updatable #3019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yndajas
force-pushed
the
1184a-delegatable-permissions-fixes-and-improvements
branch
from
607e893
to
f47036c
Compare
yndajas
force-pushed
the
1184b-always-show-view-permissions-link
branch
from
239f98e
to
8c559b4
Compare
yndajas
commented
Jul 11, 2024
yndajas
force-pushed
the
1184b-always-show-view-permissions-link
branch
from
8c559b4
to
63ea311
Compare
yndajas
force-pushed
the
1184a-delegatable-permissions-fixes-and-improvements
branch
from
f47036c
to
d1b2aae
Compare
yndajas
force-pushed
the
1184b-always-show-view-permissions-link
branch
from
63ea311
to
dc64a1d
Compare
Previously on the applications pages the view permissions link wouldn't show if the user could edit permissions. However, we'll soon fix delegatable permissions, which will mean that publishing managers will only see delegatable permissions on the update permissions page. It would be useful for them to be able to see all permissions, even if they can't grant non-delegatable ones, so we should show the view link regardless of update authorisation
yndajas
force-pushed
the
1184b-always-show-view-permissions-link
branch
from
dc64a1d
to
fe9cd78
Compare
brucebolt
approved these changes
Jul 15, 2024
yndajas
merged commit 11fe972
into
1184a-delegatable-permissions-fixes-and-improvements
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
Previously on the applications pages the view permissions link wouldn't show if the user could edit permissions. However, we'll soon fix delegatable permissions, which will mean that publishing managers will only see delegatable permissions on the update permissions page. It would be useful for them to be able to see all permissions, even if they can't grant non-delegatable ones, so we should show the view link regardless of update authorisation
Screenshots
Before
After
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.