Add Rake task to remove inappropriately-granted perms #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gweaton
force-pushed
the
add-rake-task-to-revoke-permissions
branch
from
31bb349
to
2642c06
Compare
yndajas
force-pushed
the
add-rake-task-to-revoke-permissions
branch
from
2642c06
to
59c2c9c
Compare
and update use in tests. Co-authored-by: Ynda Jas <yndajas@gmail.com>
These would have had incorrect delegatable/grantable_from_ui values in some tests - there weren't any failures, but this represents reality better. Co-authored-by: Ynda Jas <yndajas@gmail.com>
These have been identified as inappropriately granted to non-GDS users as part of an exercise to clean up the data after having fixed the way delegatable permissions work. We need to remove these permissions from non-GDS users We're using quite a few methods in the tests, which might feel a little overkill for a single-use Rake task, but we opted for this in order to cut down the number of lines required for all the setup and assertion logic and limit the chance of mistyping any of the important details Co-authored-by: George Eaton <george@dxw.com> User input stubbing taken from: https://medium.com/@bschwartz92/testing-i-o-in-ruby-with-minitest-f775133adf6c
yndajas
force-pushed
the
add-rake-task-to-revoke-permissions
branch
from
59c2c9c
to
4767d16
Compare
yndajas
changed the title
brucebolt
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
These have been identified as inappropriately granted to non-GDS users as part of an exercise to clean up the data after having fixed the way delegatable permissions work. We need to remove these permissions from non-GDS users
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.