Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rake task to remove inappropriately-granted perms #3151

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Add Rake task to remove inappropriately-granted perms #3151

merged 3 commits into from
Sep 10, 2024

Commits on Sep 9, 2024

  1. Add name to gds_organisation factory 

    and update use in tests.

Co-authored-by: Ynda Jas <yndajas@gmail.com>
    @Gweaton @yndajas
    Gweaton and yndajas committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9abbbd6 View commit details
    Browse the repository at this point in the history

  2. Ensure we're creating signin permission correctly in factory 

    These would have had incorrect delegatable/grantable_from_ui values in
some tests - there weren't any failures, but this represents reality
better.

Co-authored-by: Ynda Jas <yndajas@gmail.com>
    @Gweaton @yndajas
    Gweaton and yndajas committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    b2843be View commit details
    Browse the repository at this point in the history

  3. Add Rake task to remove inappropriately-granted perms 

    These have been identified as inappropriately granted to non-GDS users
as part of an exercise to clean up the data after having fixed the way
delegatable permissions work. We need to remove these permissions from
non-GDS users

We're using quite a few methods in the tests, which might feel a little
overkill for a single-use Rake task, but we opted for this in order to
cut down the number of lines required for all the setup and assertion
logic and limit the chance of mistyping any of the important details

Co-authored-by: George Eaton <george@dxw.com>

User input stubbing taken from: https://medium.com/@bschwartz92/testing-i-o-in-ruby-with-minitest-f775133adf6c
    @yndajas
    yndajas committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4767d16 View commit details
    Browse the repository at this point in the history