Display success banner when adding or removing access to an application (take 2) #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gweaton
changed the title
This is set to the Success Alert's param called `description` rather than `message`, so calling it `message` which is used for the header to the banner is misleading.
This felt a bit much to take in, I find it a little more readable now.
We'll shortly be adding success alerts for adding and removing access, so being able to pass in message and description in the controller makes this simple. We need to include `ActionView::Helpers::TagHelper` in the helper here to make the `tag` method available to be called in controllers. We could include it directly in the controller but including it in the helper itself means we're less likely to forget this. Unforunately we can't call `serialize` in the helper/controller as the escaping is stripped out when it's serialized as JSON when stored as a browser cookie. [1] This same serialization is what converts symbols to strings, meaning we also can't pass `flash[:success_alert]` to the Success Alert, as the `message` and `description` keys are converted to strings to store in the cookie, while the component expected an object with symbol keys.[2] [1]: https://groups.google.com/g/rubyonrails-core/c/z52zgDgUmbs [2]: bigbinary.com/blog/flash-access-changes-rails-4-1
Gweaton
force-pushed
the
success-banner-2
branch
from
4752dfd
to
658aa6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Changes in this PR
This is (I feel) a neater, second attempt at #3171 with less complexity and is more easily extensible.
We previously displayed a success alert banner when one's own or another user's permissions were updated, but didn't show anything when granting access or removing it. We now display the same banner with different messaging when a user's access is granted or removed.
The API Users journey didn't need updating here, as we already show flash messages when an API token is created or revoked, as well as when permissions are updated.
Screenshots
Granting own access
Removing own access
Granting another user access
Removing another user's access
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.