Use password input component #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes an update to the password input to allow a custom name, which we need for Devise compatibility (without undue hacking)
There's now a password input component in govuk_publishing_components, implementing the password input from GOV.UK Design System v5. This adds a show/hide password button when JavaScript is enabled, which has previously been requested by a Signon user for accessibility purposes
The show/hide button cuts into the space for the password input. In order for the email and password inputs to stay the same width, we need to add padding to the email input's wrapper equal to the space taken up by the show/hide button (including margin) We only want this change to apply to the signin form, not anywhere we have an email input, like on the create/invite new user page. I've used the form action in the selector to make this specific, which is a bit unconventional - we could add and use a class instead, but this works without changing the template. It is however reliant on the Device new session path not changing
brucebolt
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
Updates the login screen to use the new password input from GOV.UK Publishing Components (an implementation of the component added in GOV.UK Design System v5)
Screenshots
Login screen
Before
After
Create/invite new user screen (no changes expected)
Before
After
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.