Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use password input component #3176

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Use password input component #3176

merged 3 commits into from
Sep 19, 2024

Commits on Sep 19, 2024

  1. Upgrade govuk_publishing_components to 43.3.0 

    This includes an update to the password input to allow a custom name,
which we need for Devise compatibility (without undue hacking)
    @yndajas
    yndajas committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    df31d79 View commit details
    Browse the repository at this point in the history

  2. Use password input component 

    There's now a password input component in govuk_publishing_components,
implementing the password input from GOV.UK Design System v5. This adds
a show/hide password button when JavaScript is enabled, which has
previously been requested by a Signon user for accessibility purposes
    @yndajas
    yndajas committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    775e509 View commit details
    Browse the repository at this point in the history

  3. Keep email and password input widths equal 

    The show/hide button cuts into the space for the password input. In
order for the email and password inputs to stay the same width, we need
to add padding to the email input's wrapper equal to the space taken up
by the show/hide button (including margin)

We only want this change to apply to the signin form, not anywhere we
have an email input, like on the create/invite new user page. I've used
the form action in the selector to make this specific, which is a bit
unconventional - we could add and use a class instead, but this works
without changing the template. It is however reliant on the Device new
session path not changing
    @yndajas
    yndajas committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    c5e062e View commit details
    Browse the repository at this point in the history