Simplify organisation selection #3178
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These aren't used anywhere and have no tests
This gives GOV.UK admins access to all organisations and everyone else access to none, but it's only used in places that are accessible only to GOV.UK admins (also based on the organisation policy), so this is a bit of a double-authentication situation
We order them by name in a few places. In the organisations index they're in whatever order the database returns them in, which feels odd. This adds a sensible default for now
These are essentially doing the same thing, so there's no need to have multiple methods for them
This wasn't being used in the organisations index. We had custom logic which resulted in organisations without abbreviations having empty brackets after their name, which looked odd. This method separates the name and abbreviation with a dash rather than putting the abbreviation in brackets, but there doesn't seem to be an obvious reason why both uses can't be the same The dash used in the method was a non-standard character, so that's fixed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
TODO: update tests
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.