Bump govuk_sidekiq from 8.0.1 to 9.0.0 #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [govuk_sidekiq](https://github.com/alphagov/govuk_sidekiq) from 8.0.1 to 9.0.0. - [Changelog](https://github.com/alphagov/govuk_sidekiq/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk_sidekiq@v8.0.1...v9.0.0) --- updated-dependencies: - dependency-name: govuk_sidekiq dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs. Follow these steps if you are doing a Rails upgrade. |
This application uses the `redis` gem in `VolatileLock` but relied on it being included by `govuk_sidekiq`. As `govuk_sidekiq` no longer includes this dependency, we need to explicitly require it in this app.
We have upgraded `rack` from 2.2.9 to 3.1.7 as part of the Sidekiq 7 upgrade. As of version 3.0.0 of `rack`, there is a change where cookie attributes are now lowercase [1], so we need to update the test to reflect this. 1: https://github.com/rack/rack/blob/main/CHANGELOG.md#changed-2
We have now upgraded to Sidekiq 7, so don't need to require strict arguments in preparation for switching, as this version includes that requirement by default.
|
We don't need to rename the workers in this app, as it uses |
Gweaton
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps govuk_sidekiq from 8.0.1 to 9.0.0.
Changelog
Sourced from govuk_sidekiq's changelog.
Commits
946dd53Merge pull request #115 from alphagov/sidekiq-mobbing289da44Release version 9.0.0 of the gem749f82bAdd rake task to remove Redis namespacinga89c0b9Add upgrade instructions for Sidekiq 797050fbUpgrade Sidekiq to version 7.034c94eaRemoveredis-namespacedependency578789eSwitch fromredistoredis-client53c521aMerge pull request #114 from alphagov/dependabot/bundler/rubocop-govuk-eq-5.0.2c8b44f0Update rubocop-govuk requirement from = 5.0.1 to = 5.0.22e5127aMerge pull request #113 from alphagov/dependabot/bundler/rubocop-govuk-eq-5.0.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)