Add support for advertising-only sensors #985
qwandorAnnotations
11 warnings
|
single-character string constant used as pattern:
mijia-homie/src/main.rs#L122
warning: single-character string constant used as pattern
--> mijia-homie/src/main.rs:122:46
|
122 | self.mac_address.to_string().replace(":", "")
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
|
single-character string constant used as pattern:
mijia-homie/src/mijia-history-influx.rs#L109
warning: single-character string constant used as pattern
--> mijia-homie/src/mijia-history-influx.rs:109:61
|
109 | .add_tag("node_id", mac_address.to_string().replace(":", ""))
| ^^^ help: try using a `char` instead: `':'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
|
the borrowed expression implements the required traits:
mijia-homie/src/mijia-names.rs#L94
warning: the borrowed expression implements the required traits
--> mijia-homie/src/mijia-names.rs:94:15
|
94 | .open(&sensor_names_filename)?;
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `sensor_names_filename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
the loop variable `i` is used to index `new_state`:
applehat/src/ui.rs#L161
warning: the loop variable `i` is used to index `new_state`
--> applehat/src/ui.rs:161:18
|
161 | for i in 0..3 {
| ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator and enumerate()
|
161 | for (i, <item>) in new_state.iter().enumerate() {
| ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
applehat/src/ui.rs#L96
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> applehat/src/ui.rs:96:21
|
96 | &value,
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
casting to the same type is unnecessary (`u8` -> `u8`):
applehat/src/ui.rs#L68
warning: casting to the same type is unnecessary (`u8` -> `u8`)
--> applehat/src/ui.rs:68:64
|
68 | self.pixels.pixels[NUM_PIXELS - 1 - i] = [r, g, b, self.selected_brightness as u8];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.selected_brightness`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
variable does not need to be mutable:
homie-controller/src/lib.rs#L544
warning: variable does not need to be mutable
--> homie-controller/src/lib.rs:544:24
|
544 | Ok(mut property) => {
| ----^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
|
question mark operator is useless here:
mijia/src/lib.rs#L420
warning: question mark operator is useless here
--> mijia/src/lib.rs:420:9
|
420 | Ok(self.bt_session.stop_notify(&characteristic.id).await?)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `self.bt_session.stop_notify(&characteristic.id).await`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
|
|
question mark operator is useless here:
mijia/src/lib.rs#L404
warning: question mark operator is useless here
--> mijia/src/lib.rs:404:9
|
404 | / Ok(self
405 | | .bt_session
406 | | .start_notify(&history_records_characteristic.id)
407 | | .await?)
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
help: try removing question mark and `Ok()`
|
404 ~ self
405 + .bt_session
406 + .start_notify(&history_records_characteristic.id)
407 + .await
|
|
|
question mark operator is useless here:
mijia/src/lib.rs#L347
warning: question mark operator is useless here
--> mijia/src/lib.rs:347:9
|
347 | / Ok(self
348 | | .bt_session
349 | | .write_characteristic_value(&characteristic.id, HISTORY_DELETE_VALUE)
350 | | .await?)
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
help: try removing question mark and `Ok()`
|
347 ~ self
348 + .bt_session
349 + .write_characteristic_value(&characteristic.id, HISTORY_DELETE_VALUE)
350 + .await
|
|
|
question mark operator is useless here:
mijia/src/lib.rs#L289
warning: question mark operator is useless here
--> mijia/src/lib.rs:289:9
|
289 | / Ok(self
290 | | .bt_session
291 | | .write_characteristic_value(&characteristic.id, unit.encode())
292 | | .await?)
| |____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `#[warn(clippy::needless_question_mark)]` on by default
help: try removing question mark and `Ok()`
|
289 ~ self
290 + .bt_session
291 + .write_characteristic_value(&characteristic.id, unit.encode())
292 + .await
|
|