Add support for advertising-only sensors #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 51.38% 55.36% +3.97%
==========================================
Files 35 42 +7
Lines 5704 6750 +1046
==========================================
+ Hits 2931 3737 +806
- Misses 2773 3013 +240
|
qwandor
force-pushed
the
btsensor
branch
4 times, most recently
from
3a2aad9
to
de77dea
Compare
alsuren
reviewed
Jul 19, 2023
btsensor/src/bthome.rs
Outdated
| /// | ||
| /// In other words, the value stored should be divided by 10 to the power of this number to get | ||
| /// the actual value. | ||
| fn decimal_point(self) -> i32 { |
There was a problem hiding this comment.
I would probably call this denominator or something, and make it return an integer or float (1.0 or 100.0 or 1000.0)
qwandor
force-pushed
the
btsensor
branch
2 times, most recently
from
d9d226c
to
6a6f4ad
Compare
It's only needed for decoding.
qwandor
force-pushed
the
btsensor
branch
2 times, most recently
from
d2afe32
to
b05902d
Compare
Distinguish between integer and float properties.
This reduces the amount of duplication.
We were skipping 4 bytes rather than 3.
It can be shared with BTHome v2.
They are pretty similar to v1 events, so reuse the same types.
qwandor
force-pushed
the
btsensor
branch
2 times, most recently
from
d9b7fa0
to
b9f5389
Compare
alsuren
approved these changes
Aug 19, 2023
btsensor/src/bthome/v1.rs
Outdated
| } | ||
|
|
||
| /// Attempts to decode the given service data as a BTHome v1 advertisement. | ||
| pub fn decode(mut data: &[u8]) -> Result<Vec<Element>, DecodeError> { |
There was a problem hiding this comment.
(optional suggestion) move this onto Element and call it decode_all()?
| { 0x00, PacketId, u8, read_u8, "packet ID", "" }, | ||
| { 0x51, Acceleration, u16, read_u16, "acceleration", "m/s²" }, | ||
| { 0x01, Battery, u8, read_u8, "battery", "%"}, | ||
| { 0x12, Co2, u16, read_u16, "CO2", "ppm"}, |
There was a problem hiding this comment.
what order are these in? Is that how they're listed in the spec?
There was a problem hiding this comment.
Yes, this is the order from the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.