Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Data.Equality.Graph.Dot module compile again #31

Merged
merged 4 commits into from
Oct 22, 2023

Conversation

BinderDavid
Copy link
Contributor

I haven't looked at whether the generated dot files are sensible, i.e. this doesn't solve #26 yet, I only took care that the module compiles again.
More concretely:

  • The bounds on the Graphviz dependency fixed a very ancient version of that library. I don't know whether there was a specific reason for that, but I didn't get it to compile on modern GHCs.
  • Adapted the imports and the constructors to the current state of the data types.
  • Added additional CI which tests that you can build the Data.Equality.Graph.Dot module

I don't know if I have enough time before our meeting to implement improved dot file generation, I have to pack tomorrow :)

@BinderDavid
Copy link
Contributor Author

The CI build times for the Graphviz modules are with a cold cache. You can take a look at the build times in BinderDavid#1 for how it looks like with a cache hit. Then it should be ~2min faster.

@alt-romes
Copy link
Owner

Excelent!

This is good incremental progress 👍, no hurries here!

@alt-romes alt-romes merged commit 49229d1 into alt-romes:master Oct 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants