Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session management #20

Merged
merged 18 commits into from
Sep 27, 2024
Merged

Session management #20

merged 18 commits into from
Sep 27, 2024

Conversation

alyssaruth
Copy link
Owner

This PR's going to end up being quite big, essentially the aims are:

  • Introduce new session management with a /begin-session endpoint
  • Make this endpoint also populate the legacy UserConnection stuff
  • Replace the old client-side "login" flow with the new /begin-session, calling back into legacy code to proceed from there.

This has meant making various simplifications to the legacy stuff:

  • No longer connect on a "port range", the server will just listen for legacy requests on port 1142
  • Hardcode a symmetric key to be used in the legacy communication, so we can cut out having to agree one etc

@alyssaruth alyssaruth marked this pull request as ready for review September 27, 2024 20:34
@alyssaruth alyssaruth merged commit 39d3e34 into main Sep 27, 2024
3 checks passed
@alyssaruth alyssaruth deleted the begin-session branch September 27, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant