Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the variability of using different positive pins for COMP2 #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add the variability of using different positive pins for COMP2 #66

wants to merge 1 commit into from
+45 −4

Conversation

cvetaevvitaliy
Copy link
Contributor

  • add the variability of using different positive pins for COMP2: PB4, PB6, PA3

@freasy
Copy link
Collaborator

freasy commented Sep 30, 2024

Please explain your reason for this PR.

Is the new target connected to the code? We separet code and target/hardware-group PRs to not get them mixed up.

@cvetaevvitaliy
Copy link
Contributor Author

cvetaevvitaliy commented Sep 30, 2024 •
edited
Loading

@freasy Hi. This PR will allow COMP2 to use PB4, PB6, PA3 pins.
In my opinion, this will allow more flexible use of different MCU pins to create new targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cvetaevvitaliy @freasy