dshot: fixed timer wrap bug in DShot decode #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freasy
approved these changes
Aug 29, 2024
when a 16 bit timer is being used for DShot capture wraps we get dma_buffer[] values that wrap back from 655xx to low values. The subtraction needs to be done as uint16_t to cope correctly with the wrap this fixes a bug that caused dshot_badcount to tick over on each timer wrap where a DShot pulse was present
tridge
force-pushed
the
pr-DShot-decode-fix
branch
from
d1920e2
to
747b63d
Compare
AlkaMotors
approved these changes
Sep 12, 2024
freasy
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a 16 bit timer is being used for DShot capture wraps we get dma_buffer[] values that wrap back from 655xx to low values. The subtraction needs to be done as uint16_t to cope correctly with the wrap
this fixes a bug that caused dshot_badcount to tick over on each timer wrap where a DShot pulse was present
the screenshot below shows the dma_buffer[] in a debug session when the bug happens: