-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reintroduce input capture filter #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great to see the input filtering!
some of the new targets don't build, for example AM32_FLYWOO_F4A_F421 fails with:
Mcu/f421/Src/phaseouts.c: In function 'comStep':
Mcu/f421/Src/phaseouts.c:332:24: error: 'PHASE_C_COMP' undeclared (first use in this function)
332 | CMP->ctrlsts = PHASE_C_COMP;
| ^~~~~~~~~~~~
Mcu/f421/Src/phaseouts.c:339:24: error: 'PHASE_A_COMP' undeclared (first use in this function)
339 | CMP->ctrlsts = PHASE_A_COMP;
| ^~~~~~~~~~~~
Mcu/f421/Src/phaseouts.c:346:24: error: 'PHASE_B_COMP' undeclared (first use in this function)
346 | CMP->ctrlsts = PHASE_B_COMP;
| ^~~~~~~~~~~~
you can see this in the CI build tests
also, a minor thing, it is a good idea to use a branch other than 'main' for PRs, for example 'pr-input-filter' would be good, makes it easier to track
Whats wrong with these targets? It builds in Keil. The hardware group is defined. Edit. Oh the name om Flywoos target starts with am32. Does this double name cause problems. Ill check |
I've put a branch here with fixes to the issues: |
No description provided.