removed dead variables and make variables static #82
+161
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
force-pushed
the
pr-static-remove-vars
branch
2 times, most recently
from
61fc7f0
to
3f01bf2
Compare
|
Please don't mix code PRs with new targets. |
this saves a bunch of flash space and lets the compiler do a better job of optimising
tridge
force-pushed
the
pr-static-remove-vars
branch
from
3f01bf2
to
f9e3d3c
Compare
sorry about that, fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this saves a bit of flash space and lets the compiler do a better job of optimising
by making variables static we can see which variables are unused (the compiler will throw an error for an unused static variable)
initialising a global variable to zero isn't needed as each MCU startup auto-zeros the BSS
this PR is not at all urgent of course