Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive top bar layout & Fix typo #4

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

sebastianwachter
Copy link

  • Refactor top bar (port selection/connect/disconnect select and button elements) to be more responsive
  • Fix horizontal scroll bar on smaller screens
  • Fix typo in index.md

@freasy
Copy link
Collaborator

freasy commented Jun 29, 2024

Thank you for your contribution! :)

image
Can you make "read/save" right align please.

image
If getting smaller, it will overlap again. Its fine i guess, but making it another row would work here i think.

Also please change pr branch against develop please.

@sebastianwachter sebastianwachter changed the base branch from master to develop June 30, 2024 14:52
@sebastianwachter
Copy link
Author

sebastianwachter commented Jun 30, 2024

Initially I opened this PR without ever connecting an ESC because I was at work so I couldn't see the read/save buttons .😅

I fixed your requested changes in the latest update - however I had to add 2 more responsive breakpoints to tailwind.config.ts so the imo most optimal usage of screen space is achieved. I named them because of lack of any creativity: ml because the size is in between the medium (md) and large (lg) tailwind default breakpoints, and 3xl because it's bigger than the 2xl default breakpoint. :)

On very small screen sizes like mobile phones it's still not very usable but I think this is okay since there probably aren't many people flashing their ESCs using a mobile anyway. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants