fix: Replace pkg_resources with importlib.metadata #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeCoull
reviewed
Apr 3, 2024
| @@ -39,9 +38,7 @@ | |||
| from braket.tasks.local_quantum_task import LocalQuantumTask | |||
| from braket.tasks.local_quantum_task_batch import LocalQuantumTaskBatch | |||
|
|
|||
| _simulator_devices = { | |||
There was a problem hiding this comment.
Hi, thank you for the contribution!
Seems that Python 3.9 has a different behavior for using entry_points
There was a problem hiding this comment.
@math411 thanks for pointing this out. Updated to use a backport for Python 3.9 as recommend by the offical doc (see the "Compatibility Note" part).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #935 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 133 133
Lines 8906 8909 +3
Branches 2007 2008 +1
=========================================
+ Hits 8906 8909 +3 ☔ View full report in Codecov by Sentry. |
AbeCoull
approved these changes
Apr 4, 2024
|
Hi @math411, thanks for the review! I don't have the write permission to the repo. Feel free to merge when you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
pkg_resourcesis deprecated since setuptools > 67.5. Import insrc/braket/devices/local_simulator.pywould cause the following warningIt might be good to replace
pkg_resourceswith other Python built-in modules, likeimportlib.metadata.Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.