Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove shifting field from testing #948

Merged
merged 4 commits into from
Apr 10, 2024
Merged

fix: remove shifting field from testing #948

merged 4 commits into from
Apr 10, 2024

Conversation

AbeCoull
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull requested a review from a team as a code owner April 10, 2024 22:07
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a60d715) to head (c7c0c02).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #948   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          134       134           
  Lines         8914      8915    +1     
  Branches      2009      2009           
=========================================
+ Hits          8914      8915    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull requested a review from speller26 April 10, 2024 22:17
@AbeCoull AbeCoull merged commit e1564a4 into main Apr 10, 2024
24 checks passed
@AbeCoull AbeCoull deleted the detune_fix branch April 10, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants