Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: add pr_title_check workflow #991

Merged
merged 3 commits into from
Jun 19, 2024
Merged

infra: add pr_title_check workflow #991

merged 3 commits into from
Jun 19, 2024

Conversation

AbeCoull
Copy link
Contributor

@AbeCoull AbeCoull commented Jun 4, 2024

Issue #, if available:

Description of changes:
This is to check the title follows the contributing guidelines Braket has laid out.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull requested a review from a team as a code owner June 4, 2024 20:20
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90f9395) to head (ad7ae96).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #991   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines         8949      8949           
  Branches      2011      2011           
=========================================
  Hits          8949      8949           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speller26
Copy link
Member

Is there a way to enforce this for the commit name rather than the PR? Since that's what actually matters for release purposes.

@AbeCoull
Copy link
Contributor Author

Is there a way to enforce this for the commit name rather than the PR? Since that's what actually matters for release purposes.

Had an offline discussion with @speller26 regarding this. Under the squash merge in Github settings, the commit message was moved from default to use PR title.

@AbeCoull AbeCoull merged commit 72b59bd into main Jun 19, 2024
25 checks passed
@AbeCoull AbeCoull deleted the pr_title branch June 19, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants