Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resnet50 posenet model for fall detection #341

Closed
wants to merge 2 commits into from

Conversation

bhavikapanara
Copy link
Contributor

Purpose

Improved Resnet50 posenet model used for fall prediction.

Approach

Resnet50 model is more accurate than MobileNet. It will help to boost fall detection accuracy.

Merge Checklist

  • The code change is tested and works locally.
  • The user and dev documentation is up to date.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

@commit-lint
Copy link

commit-lint bot commented Mar 21, 2021

Contributors

bhavikapanara

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@pep8speaks
Copy link

Hello @bhavikapanara! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 229:80: E501 line too long (84 > 79 characters)
Line 230:80: E501 line too long (97 > 79 characters)
Line 230:82: E231 missing whitespace after ','
Line 232:80: E501 line too long (128 > 79 characters)
Line 233:80: E501 line too long (101 > 79 characters)
Line 238:80: E501 line too long (89 > 79 characters)
Line 239:80: E501 line too long (84 > 79 characters)
Line 240:80: E501 line too long (88 > 79 characters)
Line 245:80: E501 line too long (91 > 79 characters)
Line 246:80: E501 line too long (86 > 79 characters)
Line 247:80: E501 line too long (91 > 79 characters)
Line 305:80: E501 line too long (93 > 79 characters)
Line 306:80: E501 line too long (96 > 79 characters)
Line 393:17: E128 continuation line under-indented for visual indent
Line 394:1: W293 blank line contains whitespace
Line 460:80: E501 line too long (80 > 79 characters)

Line 73:80: E501 line too long (92 > 79 characters)
Line 152:80: E501 line too long (81 > 79 characters)

Line 8:80: E501 line too long (83 > 79 characters)
Line 74:73: W291 trailing whitespace
Line 112:80: E501 line too long (95 > 79 characters)
Line 155:80: E501 line too long (91 > 79 characters)
Line 168:80: E501 line too long (107 > 79 characters)
Line 174:80: E501 line too long (107 > 79 characters)
Line 176:80: E501 line too long (94 > 79 characters)
Line 179:80: E501 line too long (83 > 79 characters)

Line 90:80: E501 line too long (88 > 79 characters)

@lgtm-com
Copy link

lgtm-com bot commented Mar 21, 2021

This pull request introduces 6 alerts when merging 53674b8 into 885861f - view on LGTM.com

new alerts:

  • 4 for Unused local variable
  • 2 for Unused import

@ivelin ivelin marked this pull request as draft March 21, 2021 17:15
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #341 (7015e92) into master (dce58c8) will decrease coverage by 0.28%.
The diff coverage is 93.14%.

❗ Current head 7015e92 differs from pull request most recent head 912c447. Consider uploading reports for the commit 912c447 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   94.56%   94.27%   -0.29%     
==========================================
  Files          23       26       +3     
  Lines        2228     2622     +394     
==========================================
+ Hits         2107     2472     +365     
- Misses        121      150      +29     
Impacted Files Coverage Δ
src/ambianic/pipeline/ai/pose_engine_resnet50.py 80.45% <80.45%> (ø)
src/ambianic/pipeline/ai/pose_engine_utils.py 95.40% <95.40%> (ø)
src/ambianic/pipeline/ai/fall_detect_resnet50.py 97.27% <97.27%> (ø)
src/ambianic/pipeline/interpreter.py 94.83% <0.00%> (-0.74%) ⬇️

@lgtm-com
Copy link

lgtm-com bot commented Mar 23, 2021

This pull request introduces 6 alerts when merging 912c447 into 885861f - view on LGTM.com

new alerts:

  • 4 for Unused local variable
  • 2 for Unused import

@ivelin ivelin linked an issue Mar 25, 2021 that may be closed by this pull request
@ivelin
Copy link
Collaborator

ivelin commented Mar 25, 2021

Closes ambianic/fall-detection#5

@ivelin
Copy link
Collaborator

ivelin commented Jun 8, 2021

@bhavikapanara is this PR still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use resenet50 or another more advanced posenet DNN
3 participants