Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FRQ: Test Suite based on the example dataset #44

Closed
kai-luca opened this issue Jul 8, 2024 · 0 comments · Fixed by #54
Closed

FRQ: Test Suite based on the example dataset #44

kai-luca opened this issue Jul 8, 2024 · 0 comments · Fixed by #54
Labels
new feature New feature status: done Done and ready to merge tests Improvements or additions to tests
Milestone
release v1.1.0

Comments

@kai-luca
Copy link
Contributor

kai-luca commented Jul 8, 2024

Proposed new feature or change:

We would like our test suite to only depend on the example dataset included in the repository.
This should be possible by removing the dummy data creation and downloads, as well as rewriting the data initialization for each test case so it uses our data.
Also we should increase our test coverage.
@kai-luca kai-luca added the new feature New feature label Jul 8, 2024
@kai-luca kai-luca mentioned this issue Jul 8, 2024
Closed
@kai-luca kai-luca mentioned this issue Aug 23, 2024
Merged
@hechtprojects hechtprojects added this to the release v1.1.0 milestone Oct 16, 2024
@kay-ro kay-ro linked a pull request Oct 22, 2024 that will close this issue
Document fit functions #54
Merged
@hechtprojects hechtprojects added status: done Done and ready to merge tests Improvements or additions to tests labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature New feature status: done Done and ready to merge tests Improvements or additions to tests
Projects
None yet
Milestone
release v1.1.0
Development

Successfully merging a pull request may close this issue.

Document fit functions amepproject/amep
2 participants
@hechtprojects @kai-luca