Skip to content

Commit

Permalink
Fix for ineffassign in tests (#54)
Browse files Browse the repository at this point in the history
* Fix for ineffassign in tests
* Fixes ` no Go files in /home/travis/gopath/src/github.com/amimof/node-cert-exporter` during tests
* Update Helm chart version
* Update README

Co-authored-by: Amir Mofasser <amir.mofasser@gmail.com>
  • Loading branch information
amimof and Amir Mofasser committed Mar 24, 2021
1 parent 26014e7 commit 6f4ce3e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ gocyclo: | $(GOCYCLO) ; $(info $(M) running gocyclo) @ ## Calculates cyclomatic

.PHONY: ineffassign
ineffassign: | $(INEFFASSIGN) ; $(info $(M) running ineffassign) @ ## Detects ineffectual assignments in Go code
$Q $(INEFFASSIGN) .
$Q $(INEFFASSIGN) ./...

.PHONY: misspell
misspell: | $(MISSPELL) ; $(info $(M) running misspell) @ ## Finds commonly misspelled English words
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ kubectl apply -f https://raw.githubusercontent.com/amimof/node-cert-exporter/mas

# Docker
```
docker run -p 9117:9117 amimof/node-cert-exporter --logtostderr=true --path=/etc/ssl,/dir/with/certs
docker run -p 9117:9117 amimof/node-cert-exporter --logtostderr=true --include-glob /etc/ssl/*/*.pem
```

# Helm
Expand All @@ -27,7 +27,7 @@ helm install node-cert-exporter node-cert-exporter/node-cert-exporter
# Binary
```
curl -LOs https://github.com/amimof/node-cert-exporter/releases/latest/download/node-cert-exporter-linux-amd64 && chmod +x node-cert-exporter-linux-amd64
./node-cert-exporter-linux-amd64 --path=/etc/ssl,/dir/with/certs
./node-cert-exporter-linux-amd64 --include-glob /etc/ssl/*/*.pem
```

# Building from source
Expand Down
4 changes: 2 additions & 2 deletions charts/node-cert-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 1.0.1
version: 1.1.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
appVersion: 1.0.1
appVersion: 1.1.0
sources:
- https://github.com/amimof/node-cert-exporter

0 comments on commit 6f4ce3e

Please sign in to comment.