Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to null-safety #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

devslava
Copy link

Currently this library can't be used with Flutter 2.5.0:

Error: Cannot run with sound null safety, because the following dependencies
    don't support null safety:
     - package:appbar_elevation

This PR migrates code to null-safety. To support it, Dart min version requirement should be 2.12.0.

@maherjaafar
Copy link

@amitkot any plans to merge this PR?

@maherjaafar
Copy link

You can use SliverAppBar with scrolledUnderElevation instead of this package.

Example code:

  CustomScrollView(
      slivers: [
        const SliverAppBar(
          title: Text('Dynamic elevation'),
          pinned: true,
          scrolledUnderElevation: 20,
        ),
        SliverList(
          delegate: SliverChildBuilderDelegate(
            (_, int index) {
              return ListTile(
                title: Text(index.toString()),
              );
            },
            childCount: 20,
          ),
        ),
      ],
    );

@amitkot
Copy link
Owner

amitkot commented Jul 18, 2022

@maherjaafar I no longer use this in my projects, the direction you suggest looks good!

Repository owner deleted a comment from katsavav Feb 5, 2024
Repository owner deleted a comment from tomjrtsmith Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants