DataView finished #106
Merged
DataView finished #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Celine Pöhl <celine.poehl@fau.de>
Signed-off-by: Celine Pöhl <celine.poehl@fau.de>
CelineMP
added
the
frontend
|
missing imports for icons and mui x |
|
maybe a bit weird to have selectable fields - looks like they are supposed to be editable |
Signed-off-by: Lucas-Nan <166795065+Lucas-Nan@users.noreply.github.com>
Signed-off-by: Lucas-Nan <166795065+Lucas-Nan@users.noreply.github.com>
|
@CelineMP please check linting |
Signed-off-by: Lucas-Nan <166795065+Lucas-Nan@users.noreply.github.com>
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created the following components:
DataBox is just for working. It should be replaced with the basic structure Emil did.
Inside DataBox I have written a comment what lines exactly should be moved to the final location of the DataView.
KeyValuesList is the heart of what I did. It displays a key values list and a Filterbar that filters the rows. Depending on an attribute of the data, a map button is displayed with the hover "open as map".
FilterBar is used inside KeyValuesList and shouldn't be used anywhere else.
! Please read my comments at the top of KeyValuesList regarding the installation