Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended API for Actual Use Dataset #297

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Extended API for Actual Use Dataset #297

merged 3 commits into from
Jun 18, 2024

Conversation

Ahsankkhan
Copy link
Contributor

@Ahsankkhan Ahsankkhan commented Jun 18, 2024 •
edited
Loading

Created the yaml file in datapipeline project to inject data and also added the endpoint to retrieve data.
#159

@Ahsankkhan
Extended API for the Actual Use dataset
ad13935 
Signed-off-by: Muhammad Ahsan Khan <ahsan.m.khan@fau.de>
@Ahsankkhan Ahsankkhan added the backend Issues related to the data, logic, or communication of the application label Jun 18, 2024
@Ahsankkhan Ahsankkhan self-assigned this Jun 18, 2024
@Ahsankkhan Ahsankkhan changed the base branch from main to sprint-release June 18, 2024 13:29
@Ahsankkhan Ahsankkhan linked an issue Jun 18, 2024 that may be closed by this pull request
Extend API Endpoints for Tatsächliche Nutzung (actual use) #159
Closed
Lucas-Nan
Lucas-Nan requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Lucas-Nan Lucas-Nan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename yaml to actualUse Dataset instead of tatsächlicheNutzung. also better in db. if not wanted then at least tasaechliche instead of just an a

@Superschnizel
Copy link
Contributor

Or just remove the File because all necessary files were added in #294

@Lucas-Nan
Copy link
Contributor

oh yes.. so +1 for removal

@Ahsankkhan
Copy link
Contributor Author

Or just remove the File because all necessary files were added in #294

Removed the yaml file

@Lucas-Nan
Copy link
Contributor

please write an example how an example call would look like. this makes it easier to test it out with a new endpoit

Lucas-Nan
Lucas-Nan approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@Lucas-Nan Lucas-Nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is okay. request parameters will be refactored in another pr

@Lucas-Nan Lucas-Nan merged commit b1da1af into sprint-release Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucas-Nan Lucas-Nan Lucas-Nan approved these changes

Assignees

@Ahsankkhan Ahsankkhan

Labels
backend Issues related to the data, logic, or communication of the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend API Endpoints for Tatsächliche Nutzung (actual use)
3 participants
@Ahsankkhan @Superschnizel @Lucas-Nan