Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend - 3D View, Data view and bugs #392

Merged
merged 27 commits into from
Jul 13, 2024
Merged

Frontend - 3D View, Data view and bugs #392

merged 27 commits into from
Jul 13, 2024

Conversation

Corgam
Copy link
Collaborator

@Corgam Corgam commented Jul 10, 2024 •
edited
Loading

Corgam added 13 commits July 7, 2024 15:28
@Corgam
Fixed the styling of polygons
12ac970 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Changed the location data output
b1d1df8 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Merge branch 'sprint-release' into dev-eb
b8e2674
@Corgam
Fixed FE issues after chaning location response
3955c55 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Added random ID for rows
36e49b6 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Reimplemented 3D view
81d8fe4 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Fixed closing issues
e869936 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Added fake zoom buttons for 3D
0970781 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Fixed resizing of 3D view
b49c30d 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
3D component cleanup
7e5d1d3 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Cleanup
df4749d 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Final 3D cleanup
f5feffa 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Disabling draw polygon in 3D
e20bf7b 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam Corgam marked this pull request as draft July 10, 2024 16:47
@Corgam
Fixed search bar bug
fca2053 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Map type now stays on tab switch
f35e607 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Fixed polygon reseting on tab switch
600b996 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Fixed padding issues
efd01a1 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Started working on the multi row data view
501f855 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam Corgam changed the title Frontend - 3D View Frontend - 3D View, Data view and bugs Jul 10, 2024
@Corgam Corgam added bug Something isn't working frontend Issues related to the user interface of a web application labels Jul 10, 2024
@Corgam
Added fly to button
e190728 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Fixed some fly to bugs
c40ce24 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Optimized datasets fetching
06b87af 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Final data view styling
62ad4da 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Fixed fly to with tabs that are already opened
319f1f8 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam
Reverted mock data
4c6e5e9 
Signed-off-by: Emil Balitzki <emil.balitzki@gmail.com>
@Corgam Corgam marked this pull request as ready for review July 12, 2024 13:51
@Corgam Corgam self-assigned this Jul 12, 2024
@Corgam Corgam changed the base branch from main to sprint-release July 12, 2024 13:56
Lucas-Nan
Lucas-Nan previously requested changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Lucas-Nan Lucas-Nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error in datapipeline for ./yaml-data/hausumringe_mittelfranken_small.zip
Established the database connection.
2024-07-13 08:27:55 Starting Importer
2024-07-13 08:27:55 Opening local Zip file ./yaml-data/hausumringe_mittelfranken_small.zip
2024-07-13 08:27:55 Creating Table...
2024-07-13 08:27:55 Table created.
2024-07-13 08:27:55 Error inserting into Database:
2024-07-13 08:27:55 System.InvalidCastException: Unable to cast object of type 'System.Double' to type 'System.String'.
2024-07-13 08:27:55 at BIE.DataPipeline.Import.ShapeImporter.ReadLine(String& nextLine) in /app/src/BIE.DataPipeline/Import/ShapeImporter.cs:line 150
2024-07-13 08:27:55 at Program.

$(String[] args) in /app/src/BIE.DataPipeline/Program.cs:line 109
2024-07-13 08:27:55 --------------------------------------------------------------
2024-07-13 08:27:55 Data insertion completed! Data Pipeline has finished.

@Corgam
Copy link
Collaborator Author

Corgam commented Jul 13, 2024

Oh, forgot to merge the fix from sprint-release now it should work.

@Corgam Corgam requested a review from Lucas-Nan July 13, 2024 08:50
Lucas-Nan
Lucas-Nan approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@Lucas-Nan Lucas-Nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! popup works, marker is positioned correctly, all tickets are fulfilled

@Lucas-Nan Lucas-Nan merged commit 0ea60a5 into sprint-release Jul 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucas-Nan Lucas-Nan Lucas-Nan approved these changes

@CelineMP CelineMP Awaiting requested review from CelineMP

Assignees

@Corgam Corgam

Labels
bug Something isn't working frontend Issues related to the user interface of a web application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Corgam @Lucas-Nan