Skip to content

Fixed Windows nameserver detection by only enumerating real NICs #97

Fixed Windows nameserver detection by only enumerating real NICs

Fixed Windows nameserver detection by only enumerating real NICs #97

Re-run triggered January 30, 2024 22:42
Status Failure
Total duration 48s
Artifacts

ci.yml

on: pull_request
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

18 errors and 10 warnings
RiskyTruthyFalsyComparison: src/DnsConfig.php#L172
src/DnsConfig.php:172:13: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
RiskyTruthyFalsyComparison: src/HostLoader.php#L39
src/HostLoader.php:39:17: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
InvalidArgument: src/Internal/Socket.php#L167
src/Internal/Socket.php:167:41: InvalidArgument: Argument 1 of _home_runner_work_dns_dns_src_Internal_Socket_php_167_4817::__construct expects ArrayObject<array-key, mixed>, but ArrayObject<int, object{deferred:Amp\DeferredFuture|null, question:LibDNS\Records\Question}> provided (see https://psalm.dev/004)
RiskyTruthyFalsyComparison: src/UnixDnsConfigLoader.php#L45
src/UnixDnsConfigLoader.php:45:13: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
RiskyTruthyFalsyComparison: src/UnixDnsConfigLoader.php#L112
src/UnixDnsConfigLoader.php:112:13: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
InvalidNullableReturnType: src/WindowsDnsConfigLoader.php#L88
src/WindowsDnsConfigLoader.php:88:38: InvalidNullableReturnType: The declared return type 'string' for /home/runner/work/dns/dns/src/windowsdnsconfigloader.php:88:2828:-:closure is not nullable, but 'null|string' contains null (see https://psalm.dev/144)
NullableReturnStatement: src/WindowsDnsConfigLoader.php#L88
src/WindowsDnsConfigLoader.php:88:48: NullableReturnStatement: The declared return type 'string' for /home/runner/work/dns/dns/src/windowsdnsconfigloader.php:88:2828:-:closure is not nullable, but the function returns 'null|string' (see https://psalm.dev/139)
PHP 8.2
Process completed with exit code 2.
RiskyTruthyFalsyComparison: src/DnsConfig.php#L172
src/DnsConfig.php:172:13: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
RiskyTruthyFalsyComparison: src/HostLoader.php#L39
src/HostLoader.php:39:17: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
InvalidArgument: src/Internal/Socket.php#L167
src/Internal/Socket.php:167:41: InvalidArgument: Argument 1 of _home_runner_work_dns_dns_src_Internal_Socket_php_167_4817::__construct expects ArrayObject<array-key, mixed>, but ArrayObject<int, object{deferred:Amp\DeferredFuture|null, question:LibDNS\Records\Question}> provided (see https://psalm.dev/004)
RiskyTruthyFalsyComparison: src/UnixDnsConfigLoader.php#L45
src/UnixDnsConfigLoader.php:45:13: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
RiskyTruthyFalsyComparison: src/UnixDnsConfigLoader.php#L112
src/UnixDnsConfigLoader.php:112:13: RiskyTruthyFalsyComparison: Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
InvalidNullableReturnType: src/WindowsDnsConfigLoader.php#L88
src/WindowsDnsConfigLoader.php:88:38: InvalidNullableReturnType: The declared return type 'string' for /home/runner/work/dns/dns/src/windowsdnsconfigloader.php:88:2828:-:closure is not nullable, but 'null|string' contains null (see https://psalm.dev/144)
NullableReturnStatement: src/WindowsDnsConfigLoader.php#L88
src/WindowsDnsConfigLoader.php:88:48: NullableReturnStatement: The declared return type 'string' for /home/runner/work/dns/dns/src/windowsdnsconfigloader.php:88:2828:-:closure is not nullable, but the function returns 'null|string' (see https://psalm.dev/139)
PHP 8.1
Process completed with exit code 2.
PHP 8.1 on macOS
The operation was canceled.
PHP 8.1 on Windows
The operation was canceled.
PHP 8.2
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, nick-invision/retry@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
PHP 8.2
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP 8.2
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PHP 8.1
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2, nick-invision/retry@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
PHP 8.1
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP 8.1
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
PHP 8.1 on macOS
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
PHP 8.1 on macOS
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
PHP 8.1 on Windows
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
PHP 8.1 on Windows
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/