Fixed Windows nameserver detection by only enumerating real NICs #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
force-pushed
the
enumerate-real-keluniks
branch
from
7504a54
to
ab091b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were enumerating every TCPIP interface regardless of disposition, including virtual NICs, bluetooth adapters, VPNs and disabled interfaces. It is most likely the case that valid nameserver configuration can only come from real, physical devices, which we now detect by enumerating the
NetworkCardskey first.Ref: https://stackoverflow.com/q/6393373/1041515