Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced WMIC nameserver lookup with PowerShell equivalent #116

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

Bilge
Copy link
Contributor

@Bilge Bilge commented Jan 31, 2024

Like #115 except using PowerShell instead of WMIC. Supported OOTB since Windows 8 (Windows 7 shipped with PowerShell v2, which doesn't seem to work with Select-Object; v3 minimum is required).

Advantages

  • Not deprecated.

Disadvantages

  • 45% slower than WMIC.

Recommendation

Don't merge until the latest version of Windows ships without WMIC enabled by default.

@Bilge Bilge changed the title Powershell Replaced WMIC nameserver lookup with PowerShell equivalent Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant