Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix margin usage of p.has-background in legacy theme #7496

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Fix margin usage of p.has-background in legacy theme #7496

merged 2 commits into from
Mar 21, 2023

Conversation

thelovekesh
Copy link
Collaborator

@thelovekesh thelovekesh commented Mar 21, 2023 •
edited
Loading

Summary

As discovered in #7471 (comment), updated usage(in 7996b3a) for p.has-background(if font-size is xxl) is breaking other elements with p.has-background. This PR ensures that margins only get updated if p.has-background is a descendant of .amp-wp-article-content.

Before:
image

After:
image

Checklist

  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@thelovekesh
Update margins for p.has-background if it is descendant of `.amp-wp…
e1a3e7a 
…-article-content`

- Update style.php in legacy theme
@thelovekesh thelovekesh force-pushed the fix/reader-mode/group-block branch from 40a5233 to e1a3e7a Compare March 21, 2023 16:16
@thelovekesh thelovekesh mentioned this pull request Mar 21, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023 •
edited
Loading

Plugin builds for 3af490b are ready 🛎️!

@thelovekesh @westonruter
Add docblock for adopted margin values in p.has-background
3af490b 
Co-authored-by: Weston Ruter <westonruter@google.com>
@thelovekesh thelovekesh requested a review from westonruter March 21, 2023 16:41
@thelovekesh thelovekesh added this to the v2.4.1 milestone Mar 21, 2023
westonruter
westonruter approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the specific issue, but we'll need to revisit a more holistic approach to ensure block styles are applied properly in Legacy.

@westonruter westonruter merged commit 510f89f into develop Mar 21, 2023
@westonruter westonruter deleted the fix/reader-mode/group-block branch March 21, 2023 17:05
@westonruter westonruter mentioned this pull request Mar 21, 2023
Closed
@westonruter westonruter added the Changelogged Whether the issue/PR has been added to release notes. label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

Assignees
No one assigned
Labels
Changelogged Whether the issue/PR has been added to release notes.
Projects
None yet
Milestone
v2.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@thelovekesh @westonruter