Convert to ES Modules #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrozenberg
force-pushed
the
modularize
branch
3 times, most recently
from
a3a0c74 to
b46d745
Compare
danielrozenberg
force-pushed
the
modularize
branch
from
b46d745 to
8af697e
Compare
|
@erwinmombay bump |
|
adding @powerivq for extra pair of eyes |
erwinmombay
approved these changes
Nov 15, 2023
powerivq
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use the typescript ESLint plugin to improve type safety.
I disabled all the tests that rely on the
requestmodule because Sinon can't stub ES modules, but that npm package is long deprecated, so I'm going to replace it with the built-infetchin Node and follow-up with fixing these tests as well (I created a draft PR in my own fork that is based on this PR, so you can see what I intend to do)