Replace deprecated request
module with Node's built-in fetch
function
#150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
node-fetch
so that we can mock it in tests (nock
can't mock the built-infetch
object, see nock/nock#2397), butnode-fetch
is a thin wrapper around the built-infetch
when it's available, so this is basically like using the built-in one :)Breakdown of changes:
request
withnode-fetch
nock
to mock network requests instead of stubbing the functionasync
functions