Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the cdn reporting parameter #160

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

danielrozenberg
Copy link
Member

This changes the reporting bucket names to include the CDN, and be more explicit by renaming buckets that used to be called "CDN" to be called "Google Cache", as this is what they were actually reporting.

The changes are summarized here:

Served from the Google Cache Served from publisher origin, JS from cdn.ampproject.org Served from publisher origin, JS from ampjs.org
Before this PR CDN ${channel} Origin ${channel} Origin ${channel}
After this PR Google Cache > ${channel} Publisher Origin (https://ampproject.org) > ${channel} Publisher Origin (https://ampjs.org) > ${channel}

Minor tag-along changes:

  • Replaced a few export default situations with named exports
  • [a, ...b] instead of [a].concat(b)

utils/log-target.js Outdated Show resolved Hide resolved
@danielrozenberg danielrozenberg merged commit dcef6ab into ampproject:main Dec 12, 2023
2 checks passed
@danielrozenberg danielrozenberg deleted the ampjs-support branch December 12, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants