Skip to content
Build and test

update amq-protocol #560

Sign in to view logs

update amq-protocol

update amq-protocol #560

GitHub Actions / clippy succeeded Dec 9, 2024 in 0s

clippy

4 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 4
Note 0
Help 0

Versions

  • rustc 1.83.0 (90b35a623 2024-11-26)
  • cargo 1.83.0 (5ffbef321 2024-10-29)
  • clippy 0.1.83 (90b35a6 2024-11-26)

Annotations

Check warning on line 116 in src/parsing.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

warning: the following explicit lifetimes could be elided: 'a
   --> src/parsing.rs:116:6
    |
116 | impl<'a, 'b> Compare<&'b [u8]> for ParsingContext<'a> {
    |      ^^                                           ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
    |
116 - impl<'a, 'b> Compare<&'b [u8]> for ParsingContext<'a> {
116 + impl<'b> Compare<&'b [u8]> for ParsingContext<'_> {
    |

Check warning on line 26 in src/parsing.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the following explicit lifetimes could be elided: 'a 

warning: the following explicit lifetimes could be elided: 'a
  --> src/parsing.rs:26:6
   |
26 | impl<'a> Clone for ParsingContext<'a> {
   |      ^^                           ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `-W clippy::needless-lifetimes` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
   |
26 - impl<'a> Clone for ParsingContext<'a> {
26 + impl Clone for ParsingContext<'_> {
   |

Check warning on line 180 in src/io_loop.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unnecessary closure used to substitute value for `Option::None` 

warning: unnecessary closure used to substitute value for `Option::None`
   --> src/io_loop.rs:178:25
    |
178 | /                         self.frames.poison().unwrap_or_else(|| {
179 | |                             Error::InvalidConnectionState(ConnectionState::Closed)
180 | |                         }),
    | |__________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
    = note: `-W clippy::unnecessary-lazy-evaluations` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_lazy_evaluations)]`
help: use `unwrap_or` instead
    |
178 ~                         self.frames.poison().unwrap_or({
179 +                             Error::InvalidConnectionState(ConnectionState::Closed)
180 ~                         }),
    |

Check warning on line 100 in src/channel.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (10/9) 

warning: this function has too many arguments (10/9)
   --> src/channel.rs:89:5
    |
89  | /     pub(crate) fn new(
90  | |         channel_id: ChannelId,
91  | |         configuration: Configuration,
92  | |         connection_status: ConnectionStatus,
...   |
99  | |         recovery_config: RecoveryConfig,
100 | |     ) -> Channel {
    | |________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `-W clippy::too-many-arguments` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::too_many_arguments)]`
View more details on GitHub Actions