Practice React ToDo List Code Review #3
Conversation
amrendrakind
commented
Jun 1, 2023
amrendrakind
commented
- Update Readme.md
- Add Component lifecycles
- Add Delete todo
- Linter error fixed
- Add Hamburger Menu
- Add SinglePage.js
- Update Navbar.js
- Update Router set up
- Add Router set up
- Add About and No Match pages
- Add key down events
- Add input field editable
- Linter Error fixed
- Add styling
- Add styling
- Add TodoItem.module.css
- Updated App.css
- Updated App.css
- Updated InputTodo
- Add InputTodo completed
- Add handel Submit functionality
- Add InputTodo
amrendrakind
changed the title
There was a problem hiding this comment.
Hi @amrendrakind 👋 ,
Good job so far working on the project requirements!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 🎯
- No linter errors. ✔️
- GitHub flow is followed. ✔️
- Good Pr title/description ✔️
- Good commit history ✔️
Required Changes ♻️
Kindly fix the issues described in the pr thread below in order to get an approval
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!clapclapclap
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Ol-create in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Happy coding! 🎉 🎉
src/App.test.js
Outdated
| import { render, screen } from '@testing-library/react'; | ||
| import App from './App'; | ||
|
|
||
| test('renders learn react link', () => { |
There was a problem hiding this comment.
- Please consider adding a description to the test: It's helpful to provide a description
for the test case to make it more descriptive and easier to understand. 👍
There was a problem hiding this comment.
Thank buddy, I have change the test name to be more descriptive 👍
src/components/Header.js
Outdated
| style={{ | ||
| fontSize: '6rem', | ||
| fontWeight: '600', | ||
| marginBottom: '2rem', | ||
| lineHeight: '1em', | ||
| color: '#ececec', | ||
| textTransform: 'lowercase', | ||
| textAlign: 'center', | ||
| }} |
There was a problem hiding this comment.
- I suggest you use CSS classes instead of inline styles: For better separation of concerns,
it's generally recommended to use CSS classes instead of inline styles. - You can define a CSS class for the header styles and apply it to the header element. 🎉 🎉
There was a problem hiding this comment.
I have change a new file to style the Header.js
Thanks for bringing to my awareness the separation of concerns. 💯 ❤️
There was a problem hiding this comment.
Status: Approved ✔️:confetti_ball:
Congratulations! 🎉 Project Approved ✅
Good job so far. Well Done.👍🏻
Your project is complete! There is nothing else to say other than... it's time to merge it 
To Highlight 🎉
- No linter errors. ✔️
- Git flow is followed. ✔️
- You have followed JavaScript best practices. ✔️
- Professional README file. ✔️
- PR has a good title and summary. ✔️
- Your app works as expected 💯 🥇
- Your Design looks awesome, keep rocking 🚀
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers 🥂 and Happy coding!!! 👯💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @Ol-create when you comment so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Thank you my friend for all your time and effort. 👍 |
