Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Practice React ToDo List Code Review #3

Open
wants to merge 42 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
01cb891
Add MIT.md and update Readme.md
amrendrakind May 2, 2022
6651a01
updated Readme.md
amrendrakind May 2, 2022
5c3fc44
Seeting up basic React boilerplate
amrendrakind May 3, 2022
d7d3d0c
Setting up linters
amrendrakind May 3, 2022
9fd55d1
Fixing linters
amrendrakind May 3, 2022
0cf97be
Add Todo Conatiner
amrendrakind May 3, 2022
a11a1e3
TodosList added
amrendrakind May 3, 2022
9c85c12
TodoItem added
amrendrakind May 3, 2022
05c326f
Header added
amrendrakind May 3, 2022
1ae8472
Linter error fixed
amrendrakind May 3, 2022
153feb1
TodoItem change from class to function components
amrendrakind May 3, 2022
0b700d3
Clicked handler implemented
amrendrakind May 3, 2022
6a8d652
Clicked handler using State
amrendrakind May 3, 2022
e8acfc9
Delete button added
amrendrakind May 3, 2022
916b77f
gh-pages added
amrendrakind May 3, 2022
527ca84
Add InputTodo
amrendrakind May 4, 2022
f513006
Add handel Submit functionality
amrendrakind May 4, 2022
d85ba43
Add InputTodo completed
amrendrakind May 4, 2022
1f3cec3
Updated InputTodo
amrendrakind May 4, 2022
60ad0da
Updated App.css
amrendrakind May 4, 2022
4c5178d
Updated App.css
amrendrakind May 4, 2022
6e5e235
Add TodoItem.module.css
amrendrakind May 4, 2022
d4f6f3c
Add styling
amrendrakind May 4, 2022
472426b
Add styling
amrendrakind May 4, 2022
270da91
Linter Error fixed
amrendrakind May 4, 2022
f569680
Add input field editable
amrendrakind May 4, 2022
61b9c72
Add key down events
amrendrakind May 4, 2022
540cb90
Add About and No Match pages
amrendrakind May 4, 2022
5b07d3b
Add Router set up
amrendrakind May 4, 2022
194687b
Update Router set up
amrendrakind May 4, 2022
887bd45
Update Navbar.js
amrendrakind May 4, 2022
79016fb
Add SinglePage.js
amrendrakind May 4, 2022
e42e387
Add Hamburger Menu
amrendrakind May 4, 2022
828f42b
Linter error fixed
amrendrakind May 4, 2022
e78462b
Add Delete todo
amrendrakind May 4, 2022
d5e9eb5
Add Component lifecycles
amrendrakind May 5, 2022
a31465d
Update Readme.md
amrendrakind May 5, 2022
d99e135
Update Readme.md
amrendrakind May 5, 2022
b749dcb
Merge pull request #1 from amrendrakind/todo
amrendrakind May 9, 2022
0c6cc61
Add descriptive test name
amrendrakind Jun 1, 2023
5de7cc8
Update Header.js
amrendrakind Jun 1, 2023
db4cbde
Add header css
amrendrakind Jun 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"presets": [
"@babel/preset-react"
],
"plugins": ["@babel/plugin-syntax-jsx"]
}
27 changes: 27 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"env": {
"browser": true,
"es6": true,
"jest": true
},
"parser": "@babel/eslint-parser",
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": 2018,
"sourceType": "module"
},
"extends": ["airbnb", "plugin:react/recommended"],
"plugins": ["react"],
"rules": {
"react/jsx-filename-extension": ["warn", { "extensions": [".js", ".jsx"] }],
"react/react-in-jsx-scope": "off",
"import/no-unresolved": "off",
"no-shadow": "off"
},
"ignorePatterns": [
"dist/",
"build/"
]
}
37 changes: 37 additions & 0 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Linters

on: pull_request

env:
FORCE_COLOR: 1

jobs:
eslint:
name: ESLint
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: "12.x"
- name: Setup ESLint
run: |
npm install --save-dev eslint@7.x eslint-config-airbnb@18.x eslint-plugin-import@2.x eslint-plugin-jsx-a11y@6.x eslint-plugin-react@7.x eslint-plugin-react-hooks@4.x @babel/eslint-parser@7.x @babel/core@7.x @babel/plugin-syntax-jsx@7.x @babel/preset-env@7.x @babel/preset-react@7.x
[ -f .eslintrc.json ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/react-redux/.eslintrc.json
[ -f .babelrc ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/react-redux/.babelrc
- name: ESLint Report
run: npx eslint .
stylelint:
name: Stylelint
runs-on: ubuntu-18.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: "12.x"
- name: Setup Stylelint
run: |
npm install --save-dev stylelint@13.x stylelint-scss@3.x stylelint-config-standard@21.x stylelint-csstree-validator@1.x
[ -f .stylelintrc.json ] || wget https://raw.githubusercontent.com/microverseinc/linters-config/master/react-redux/.stylelintrc.json
- name: Stylelint Report
run: npx stylelint "**/*.{css,scss}"
23 changes: 23 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage

# production
/build

# misc
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*
20 changes: 20 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"extends": ["stylelint-config-standard"],
"plugins": ["stylelint-scss", "stylelint-csstree-validator"],
"rules": {
"at-rule-no-unknown": [
true,
{
"ignoreAtRules": ["tailwind", "apply", "variants", "responsive", "screen"]
}
],
"scss/at-rule-no-unknown": [
true,
{
"ignoreAtRules": ["tailwind", "apply", "variants", "responsive", "screen"]
}
],
"csstree/validator": true
},
"ignoreFiles": ["build/**", "dist/**", "**/reset*.css", "**/bootstrap*.css", "**/*.js", "**/*.jsx"]
}
6 changes: 6 additions & 0 deletions MIT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Copyright 2022, Amrendra K
Permission is hereby granted, free of charge, to any person obtaining a copy of this ToDoApp_React_JS and associated documentation files, to deal in the ToDoApp_React_JS without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the ToDoApp_React_JS, and to permit persons to whom the ToDoApp_React_JS is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the ToDoApp_React_JS.

THE ToDoApp_React_JS IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE ToDoApp_React_JS OR THE USE OR OTHER DEALINGS IN THE ToDoApp_React_JS.
109 changes: 107 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,107 @@
# ToDoApp_React_JS
"To-do list" is a tool that helps to organize your day. It simply lists the things that you need to do and allows you to mark them as complete. I will build a simple website that allows for doing that, and I will do it React JS. It will be deploy on GitHub Pages!!
![](https://img.shields.io/badge/Microverse-blueviolet)

# Project Name : To Do Lists

> "To-do list" is a tool that helps to organize your day. It simply lists the things that you need to do and allows you to mark them as complete. I will build a simple website that allows for doing that, and I will do it using React JS. It is a Single Page App (SPA) that allows users to:

- To organize your day.

You can find live project at https://amrendrakind.github.io/ToDoApp_React_JS/

## Built With

- React JS
- JSX
- JavaScripts
- Webpack
- GitFlow

## Live Demo (Link for My To Do Lists Project)

[Live Demo Link](https://amrendrakind.github.io/ToDoApp_React_JS)

## Development set up

Clone Repository using

`git clone git@github.com:amrendrakind/ToDoApp_React_JS.git`

OR using HTTPS

`git clone https://github.com/amrendrakind/ToDoApp_React_JS.git`

move into project directory

`cd ToDoApp_React_JS`

Install Project dependancies using `NPM`

`npm install`

launch project locally with

`npm start`

## Available Scripts

In the project directory, you can run:

### `npm start`

Runs the app in the development mode.\
Open [http://localhost:3000](http://localhost:3000) to view it in your browser.

The page will reload when you make changes.\
You may also see any lint errors in the console.

### `npm test`

Launches the test runner in the interactive watch mode.\
See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information.

### `npm run build`

Builds the app for production to the `build` folder.\
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.\
Your app is ready to be deployed!

See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information.

### `npm run eject`

**Note: this is a one-way operation. Once you `eject`, you can't go back!**

If you aren't satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you're on your own.

You don't have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn't feel obligated to use this feature. However we understand that this tool wouldn't be useful if you couldn't customize it when you are ready for it.

## Author

👤 **Amrendra K**

- GitHub: [@githubhandle](https://github.com/amrendrakind)
- Twitter: [@twitterhandle](https://twitter.com/amrendrak_)
- LinkedIn: [LinkedIn](https://linkedin.com/in/amrendraakumar)

## 🤝 Contributing

Contributions, issues, and feature requests are welcome!

Feel free to check the [issues page](../../issues/).

## Show your support

Give a ⭐️ if you like this project!

## Acknowledgments

- Microverse team for guidance
- Ibas Majid

## 📝 License

This project is [MIT](./MIT.md) licensed.
Loading