Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadows are missing in FluentAvalonia 2.1.0 #601

Open
IsaacMarovitz opened this issue Aug 4, 2024 · 4 comments
Open

Shadows are missing in FluentAvalonia 2.1.0 #601

IsaacMarovitz opened this issue Aug 4, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@IsaacMarovitz
Copy link
Contributor

IsaacMarovitz commented Aug 4, 2024

This issue is visible on ContentDialogs

FluentAvalonia 2.0.5:

image

FluentAvalonia 2.1.0:

image

Probably related to AvaloniaUI/Avalonia#15602

@IsaacMarovitz IsaacMarovitz added the bug Something isn't working label Aug 4, 2024
@robloo
Copy link
Contributor

robloo commented Aug 18, 2024

Do you see the Window shadow on the desktop? What about for actual Popup/Flyout rather than overlay?

This issue is on my radar as well. I don't have shadows of any kind though. If we can narrow it down I'll definitely help fix it.

@xLEGiON
Copy link
Contributor

xLEGiON commented Oct 10, 2024

PR #541 commit "Remove uses of FABorder" added the "BackgroundSizing" attribute to the "BackgroundElement" Border in "ContentDialogStyles.axaml". Setting this to the default value of "CenterBorder" in Avalonia DevTools made the shadows re-appear for me. Maybe the attribute can just be removed.

@robloo
Copy link
Contributor

robloo commented Oct 11, 2024

Ah, thanks for confirming that's what this is. I'll try to prioritize fixing it upstream. It shouldn't be an issue as long as it isn't a performance issue.

@amwx
Copy link
Owner

amwx commented Oct 12, 2024

So my plan here was to switch from BoxShadow over to the newer Effect shadow which works with any background sizing, though it might be slightly less performant than the basic BoxShadow. If a borderbrush needs to be used, I really want to avoid CenterBorder where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants