Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adis16480 support #546

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

trishaange01
Copy link
Contributor

@trishaange01 trishaange01 commented Mar 15, 2024

Description

Add support for adis16480.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware: ADIS16480
  • OS: Windows

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@trishaange01
Copy link
Contributor Author

Hi @tfcollins. This is ready for review. Thanks :)

@trishaange01
Copy link
Contributor Author

Hi @tfcollins. I already added the missing docs. Also, the emulated tests (TEST-Emulated-HW) failed last time so I updated the xml file in test/emu/devices but I'm not sure if it's the cause of the failure.

Signed-off-by: Trisha De Vera <Trisha.Devera@analog.com>
@trishaange01
Copy link
Contributor Author

Hi @tfcollins. This PR is ready for review. Thanks! 😊

Copy link
Collaborator

@tfcollins tfcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an update on the supported parts

Signed-off-by: Trisha De Vera <Trisha.Devera@analog.com>
@tfcollins tfcollins merged commit e4585cb into analogdevicesinc:main May 7, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants