Ad9081 test fixes #566
Merged
Ad9081 test fixes #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpineda3
force-pushed
the
ad9081-test-fixes
branch
from
14bb0dc
to
d88ae33
Compare
jpineda3
force-pushed
the
ad9081-test-fixes
branch
from
d88ae33
to
f8b0e1c
Compare
tfcollins
reviewed
Aug 15, 2024
test/test_ad9081.py
Outdated
| @@ -65,6 +65,16 @@ def test_ad9081_str_attr(test_attribute_multiple_values, iio_uri, classname, att | |||
| test_attribute_multiple_values(iio_uri, classname, attr, val, 0) | |||
|
|
|||
|
|
|||
| ######################################### | |||
| @pytest.mark.iio_hardware(hardware) | |||
There was a problem hiding this comment.
This should be hardware, True. Emulation won't generate errors here
tfcollins
reviewed
Aug 15, 2024
test/rf/spec.py
Outdated
| @@ -148,6 +148,10 @@ def sfdr(x, fs=1, ref=2 ** 15, plot=False): | |||
| next = peak_vals[1] | |||
| sfdr = absolute(main - next) | |||
|
|
|||
| print(main) | |||
tfcollins
requested changes
Aug 15, 2024
Signed-off-by: Julia Pineda <Julia.Pineda@analog.com>
Signed-off-by: Julia Pineda <Julia.Pineda@analog.com>
Signed-off-by: Julia Pineda <Julia.Pineda@analog.com>
Signed-off-by: Julia Pineda <Julia.Pineda@analog.com>
Signed-off-by: Julia Pineda <Julia.Pineda@analog.com>
jpineda3
force-pushed
the
ad9081-test-fixes
branch
from
f8b0e1c
to
4be93cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
test/test_ad9081.py::test_ad9081_iq_loopback fails for variants with different sampling_frequency between rx and tx device. With these modifications, the estimated frequency at rx is within tolerance, although some tests still fail because of peak value assertions.
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: