-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for adrv9371 and adrv9009 #584
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
d206755
to
2a24252
Compare
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
Signed-off-by: Trecia Agoylo <trecia.agoylo@analog.com>
@tfcollins PR is ready for review. I updated the emulated test workflow - to run the test without the optional dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primarily just questions on the DEC8/INT8 updates
run: | | ||
pytest -vs --cov=adi --scan-verbose --emu --junitxml="results.xml" -k 'not prod' | ||
pip uninstall -y paramiko | ||
pytest -vs --scan-verbose --emu --junitxml="results.xml" -k 'not prod' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing coverage flag
avail = avail.strip().split(" ") | ||
return val == avail[1] | ||
except KeyError: | ||
return val == avail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This applies to the other blocks that share this logic.
- If sampling_frequency_available does not exist this will generate a strange error. Something like sampling_frequency_available is not a valid key, which won't make any sense. So there needs to be an except catch for that case
- The case when it does but only 1 value exists doesn't really make sense or the logic flow is convoluted. If only 1 value exists then it should always return false.
Description
This PR includes fixes for adrv9371 and adrv9009 as well as their tests.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: